Fix issue 20022: [POSIX] extern(C++, "namespace") does not apply namespace to enum#10127
Merged
thewilsonator merged 1 commit intodlang:stablefrom Jul 3, 2019
Merged
Fix issue 20022: [POSIX] extern(C++, "namespace") does not apply namespace to enum#10127thewilsonator merged 1 commit intodlang:stablefrom
thewilsonator merged 1 commit intodlang:stablefrom
Conversation
Geod24
added
the
Review:stable-priority
Contributor
|
Thanks for your pull request, @Geod24! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "stable + dmd#10127" |
ghost
approved these changes
Jul 3, 2019
thewilsonator
approved these changes
Jul 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will also add our project to buildkite so this doesn't happen again.
Since
enumwere not really tested, I also added for the non-string version.